-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup integration test with minio #81
Comments
I'll take this one if noone's assigned to it yet. |
@abyssnlp before you start, can you please elaborate on the design? |
Sure, so at a high level:
I'll add more details today after work. Please feel free to add things I should keep in mind while I work on this. |
@abyssnlp high-level looks good. a heads-up about testing data - since hudi-rs not yet supports hudi writer, we are using fixed pre-generated tables as the testing tables: see https://github.com/apache/hudi-rs/tree/main/crates/tests/data/tables Would like to see some detailed design around provisioning test tables through minio volumes |
Sorry about the delay. Something like: .with_mount(Mount::bind_mount(canonicalize(Path::new("tests/data"))?.into_os_string().into_string().unwrap(), However something that I found out about testcontainers in Rust is that it doesn't support reusing the container for multiple tests so the integration tests would be for ex. in a single test function. More about it here. There are also workarounds. Alternative would be to use So this is how I'm thinking about approaching it:
I had some questions as well.
|
@abyssnlp sounds good to make use of docker-compose - it'll be convenient to evolve the tests as we probably need to add more components in future. to answer the questions
|
Thanks for sharing your thoughts on it. I'm currently running into some issues trying to read the tables via I've tried using both environment variables ( Might be some bad configuration on my end. I'll continue working on it this week and keep posting updates here. |
@abyssnlp any plan to put this up in a PR? |
@xushiyan Yes i'll put it up in a PR soon (today or tomorrow). |
No description provided.
The text was updated successfully, but these errors were encountered: