Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure pre commit hook to format code style #73

Open
xushiyan opened this issue Jul 18, 2024 · 4 comments · May be fixed by #103
Open

Configure pre commit hook to format code style #73

xushiyan opened this issue Jul 18, 2024 · 4 comments · May be fixed by #103
Assignees
@xushiyan @muyihao
Labels
dev-x Dev experience: code format, dev tooling, project management good first issue Good for newcomers python Related to Python codebase rust Related to Rust codebase
Milestone
release-0.4.0

Comments

@xushiyan
Copy link
Member

xushiyan commented Jul 18, 2024 •
edited
Loading

should format both rust and python code
@xushiyan xushiyan added good first issue Good for newcomers dev-x Dev experience: code format, dev tooling, project management python Related to Python codebase rust Related to Rust codebase labels Jul 18, 2024
@xushiyan xushiyan added this to the release-0.2.0 milestone Jul 18, 2024
@muyihao
Copy link
Contributor

muyihao commented Jul 21, 2024

Hi, I'd like to work on this issue. Could you please assign it to me?

@xushiyan
Copy link
Member Author

@muyihao sure. Also the python formatting is not in place yet. Maybe #5 first?

@muyihao
Copy link
Contributor

muyihao commented Jul 22, 2024

@xushiyan Sure, I will start with #5 first. Thank you for the guidance!

@xushiyan
Copy link
Member Author

@muyihao Pls comment on the issue so i can assign you.

@abyssnlp abyssnlp mentioned this issue Jul 26, 2024
Closed
This was referenced Jul 27, 2024
Closed
Closed
Open
muyihao pushed a commit to muyihao/hudi-rs that referenced this issue Jul 28, 2024
chore: configure pre-commit hooks for code formatting (apache#73)
075a26e 
- Install pre-commit when using make setup.
- Add pre-commit hooks for Python and Rust code formatting.
@xushiyan xushiyan modified the milestones: release-0.2.0, release-0.3.0 Sep 15, 2024
@xushiyan xushiyan linked a pull request Nov 30, 2024 that will close this issue
chore: configure pre-commit hooks for code formatting #103
Open
4 tasks
@xushiyan xushiyan self-assigned this Nov 30, 2024
@xushiyan xushiyan modified the milestones: release-0.3.0, release-0.4.0 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xushiyan xushiyan

@muyihao muyihao

Labels
dev-x Dev experience: code format, dev tooling, project management good first issue Good for newcomers python Related to Python codebase rust Related to Rust codebase
Projects
None yet
Milestone
release-0.4.0
Development

Successfully merging a pull request may close this issue.

chore: configure pre-commit hooks for code formatting muyihao/hudi-rs
2 participants
@xushiyan @muyihao