Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: HopGuiWorkflowGridDelegate does not stop timer for auto refresh when closed #4371

Closed
nadment opened this issue Sep 29, 2024 · 0 comments · Fixed by #4372
Closed

[Bug]: HopGuiWorkflowGridDelegate does not stop timer for auto refresh when closed #4371

nadment opened this issue Sep 29, 2024 · 0 comments · Fixed by #4372
Assignees
@nadment
Labels
bug Hop Gui P3 Nice to have
Milestone
2.11

Comments

@nadment
Copy link
Contributor

nadment commented Sep 29, 2024 •
edited
Loading

Apache Hop version?

2.10.0-SNAPSHOT

Java version?

Java 17

Operating system

Windows

What happened?

HopGuiWorkflowGridDelegate doesn't stop the auto refresh timer when it's closed, causing thread accumulation.

  • I've done a bit of cleanup and adapted to the dark mode
    image

Issue Priority

Priority: 3

Issue Component

Component: Hop Gui
@nadment nadment self-assigned this Sep 29, 2024
@github-actions github-actions bot added P3 Nice to have Hop Gui labels Sep 29, 2024
nadment added a commit to nadment/hop that referenced this issue Sep 29, 2024
@nadment
HopGuiWorkflowGridDelegate does not stop timer for auto refresh when
15effff 
closed apache#4371
@nadment nadment linked a pull request Sep 29, 2024 that will close this issue
HopGuiWorkflowGridDelegate does not stop timer auto refresh #4371 #4372
Merged
@hansva hansva closed this as completed in 9b3abc6 Oct 4, 2024
hansva added a commit that referenced this issue Oct 4, 2024
@hansva
Merge pull request #4372 from nadment/4371
b89b574 
HopGuiWorkflowGridDelegate does not stop timer auto refresh #4371
@hansva hansva added this to the 2.11 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadment nadment

Labels
bug Hop Gui P3 Nice to have
Projects
None yet
Milestone
2.11
Development

Successfully merging a pull request may close this issue.

HopGuiWorkflowGridDelegate does not stop timer auto refresh #4371 nadment/hop
2 participants
@hansva @nadment