Fixes bug resolving lock w/ empty col fam. Reported in #660 #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug where if a column family was empty and the qual was not empty this would cause lock recovery to fail. The underlying cause was a bug in the Column class. This class has an isFamilySet() method that was returning false when the family was set to the empty string. This cause caused lock recovery code to create an incorrect range. The Column class was relying on internal behavior of the Bytes class that probably changed and caused this bug. This commit adds a new IT that recreates this bug. If the new IT is run w/o the fix to the Column class then it would fail as follows. ``` Running org.apache.fluo.integration.impl.FailureIT Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 8.011 sec <<< FAILURE! - in org.apache.fluo.integration.impl.FailureIT testRecoverEmptyColumn(org.apache.fluo.integration.impl.FailureIT) Time elapsed: 7.096 sec <<< ERROR! java.lang.IllegalStateException: can not abort : bob bal 5 (UNKNOWN) at org.apache.fluo.integration.impl.FailureIT.testRecoverEmptyColumn(FailureIT.java:688) ```
|
All ITs pass for ee51445 |
ctubbsii
approved these changes
Nov 16, 2022
modules/integration-tests/src/main/java/org/apache/fluo/integration/impl/FailureIT.java
Show resolved
Hide resolved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where if a column family was empty and the qual was not empty this would cause lock recovery to fail. The underlying cause was a bug in the Column class. This class has an isFamilySet() method that was returning false when the family was set to the empty string. This cause caused lock recovery code to create an incorrect range.
The Column class was relying on internal behavior of the Bytes class that probably changed and caused this bug.
This commit adds a new IT that recreates this bug. If the new IT is run w/o the fix to the Column class then it would fail as follows.