Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolled back locks may cause collisions #920

Open
keith-turner opened this issue Sep 13, 2017 · 2 comments
Open

Rolled back locks may cause collisions #920

keith-turner opened this issue Sep 13, 2017 · 2 comments

Comments

@keith-turner
Copy link
Contributor

While working on #917 I realized that rolled back locks may unnecessarily cause collisions. If a transaction could only lock a subset of columns, then it will fail and rollback the locks it did acquire. These rolled back locks should not cause other transactions to fail. It seems that the code may treat these rolled back locks as successful locks which can cause other transaction to fail unnecessarily.
@keith-turner
Copy link
Contributor Author

Further, if a transaction fails to get a lock and then rolls back an existing lock then it can re-attempt getting its lock.

@keith-turner
Copy link
Contributor Author

Also need to consider read locks if and when #917 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keith-turner