Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][UI] Fix logic_operator not passed to backend and not echoed in UI #16466

Open
3 tasks done
newbiename opened this issue Aug 15, 2024 · 6 comments · May be fixed by #16468
Open
3 tasks done

[Bug][UI] Fix logic_operator not passed to backend and not echoed in UI #16466

newbiename opened this issue Aug 15, 2024 · 6 comments · May be fixed by #16468
Assignees
Labels
bug Something isn't working Stale

Comments

@newbiename
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

The logic_operator parameter in the quality operator is not being correctly passed to the backend, nor is it properly echoed back in the UI. This issue affects the proper handling and display of the logical operators.

This is my first time contributing, and I am a beginner. Any guidance or feedback would be greatly appreciated.

What you expected to happen

The system should correctly parse and process the logic_operator parameter to ensure that all relevant logical operators work properly.

How to reproduce

Currently, the logic_operator parameter is not handled correctly, causing some functions to not work properly.

Anything else

every time

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@newbiename newbiename added bug Something isn't working Waiting for reply Waiting for reply labels Aug 15, 2024
@SbloodyS
Copy link
Member

What do you mean by The logic_operator parameter in the quality operator? I don't quite understand what this function is. @newbiename

@SbloodyS SbloodyS added need more information and removed Waiting for reply Waiting for reply labels Aug 15, 2024
@newbiename
Copy link
Author

image
Hi @SbloodyS,

The parameter is used to specify the logical operation (such as AND, OR) that should be applied within the quality operator in our system. It helps determine how different conditions are combined or evaluated.logic_operator

What it should do:

The parameter is meant to define the logical relationship between conditions. For instance, if you have multiple conditions, the determines whether they are combined using AND or OR.logic_operatorlogic_operator
Issue Details:

Currently, this parameter is not being correctly passed to the backend, which means the server-side logic may not be executed as expected.
Additionally, it’s not properly displayed in the UI, so users might not see the correct logical operations being applied.
Example:

If the is set to "AND", the backend should process the conditions such that all conditions must be true for the overall logic to be true.logic_operator
If it’s set to "OR", then only one of the conditions needs to be true.
I hope this clarifies the issue. Please let me know if you need more details or if there are any specific parts of the code that you need help with.

@SbloodyS
Copy link
Member

I see. The data-quality module is no longer maintained and will be deprecated in the future. @newbiename

@newbiename
Copy link
Author

Hi @SbloodyS,

Thank you for the information. Given that the data-quality module is being deprecated, I wanted to confirm if my PR to fix this issue will be accepted or if there is a more appropriate alternative module where this issue should be addressed.

Should I proceed with submitting the PR for this module, or would it be more appropriate to close this issue and redirect my efforts to another module?

Thanks for your guidance!

Best regards,
newbiename

@SbloodyS
Copy link
Member

SbloodyS commented Aug 15, 2024

Bug fix for data-quality module is welcome currently. I've assigned to you. Looking forward to your contribution. @newbiename

Copy link

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants