allow passing in metadata_size_hint on a per-file basis #13213
+166
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
adriangb
commented
Nov 1, 2024
alamb
reviewed
Nov 3, 2024
There was a problem hiding this comment.
Thanks @adriangb -- the code looks good to me.
However, I worry about the lack of a test. Specifically without a test of some sort I think it is likely this feature could easily get broken in a refactor and we wouldn't catch it in review
|
Amazing! Let me know what else is needed to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can only pass it to
ParquetExecBuilderbut that applies to entire groups of files. This adds an API to set it on a per-file basis in cases where you know the size of the metadata in each file. In our case we have a metadata store that stores information about each file, including the size of the metadata, so we know the exact size in bytes and can ensure that we never have to double-request to read the entire metadata.