Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manual PartialEq and Hash implementations of some PhysicalExprs added in https://github.com/apache/datafusion/pull/13005 #13196

Open
peter-toth opened this issue Oct 31, 2024 · 0 comments
Open

Remove manual PartialEq and Hash implementations of some PhysicalExprs added in https://github.com/apache/datafusion/pull/13005 #13196

peter-toth opened this issue Oct 31, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@peter-toth
Copy link
Contributor

peter-toth commented Oct 31, 2024 •
edited
Loading

Describe the bug

This is a TODO ticket that once the rust-lang/rust#78808 bug gets fixed we can switch from manual implementation of PartialEq and Hash of all PhysicalExprss to derive macro.
See details in #13005 description and #13005 (comment).

To Reproduce

No response

Expected behavior

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peter-toth