-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert BuiltInWindowFunction::{NthValue}
to a user defined functions
#12649
Comments
I think this one is also relatively straightforward and would make a good first project for someone skilled in Rust who wanted to get experience with the Datafusion codebase and tests |
take |
Convert BuiltInScalarFunction::{NthValue} -> Convert BuiltInWindowFunction::{NthValue} |
BuiltInScalarFunction::{NthValue}
to a user defined functionsBuiltInWindowFunction::{NthValue}
to a user defined functions
🤦 -- fixed |
Hi, @dharanad . If you are busy can I look into this ! |
Sure |
take |
Is your feature request related to a problem or challenge?
Part of #8709
There is now no difference between "built in" / "prepackaged" scalar and aggregate functions in DataFusion, however there are still some "built in" window functions -- see the current source for
BuiltInWindowFunction
for the up to date list of what remainsThe problem with having two different kinds of window functions is
Describe the solution you'd like
I would like to remove the "built in" version of this function and convert it to a user defined function
Describe alternatives you've considered
At a high level the process is:
functions-window
crateBuiltInWindowFunction
variant and then get everything to compile (the compiler will show you where the existing implementations are)Additional context
Here are some good examples:
RowNumber
in Convert built-inrow_number
to user-defined window function #12030The text was updated successfully, but these errors were encountered: