Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BEGIN; is formatted as BEGIN TRANSACTION;, which is invalid in MySQL #1553

Open
lovasoa opened this issue Nov 25, 2024 · 0 comments · May be fixed by #1565
Open

BEGIN; is formatted as BEGIN TRANSACTION;, which is invalid in MySQL #1553

lovasoa opened this issue Nov 25, 2024 · 0 comments · May be fixed by #1565

Comments

@lovasoa
Copy link
Contributor

lovasoa commented Nov 25, 2024

BEGIN; is valid in MySQL, but not BEGIN TRANSACTION;: https://dev.mysql.com/doc/refman/8.4/en/commit.html

But sqlparser does not preserve the exact syntax of the statement, and always formats it as BEGIN TRANSACTION;, causing an execution error in MySQL.

Found while investigating sqlpage/SQLPage#711
@mvzink mvzink linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix displaying WORK or TRANSACTION after BEGIN mvzink/datafusion-sqlparser-rs
1 participant
@lovasoa