Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Improve sqlparser performance #1557

Open
alamb opened this issue Nov 26, 2024 · 0 comments
Open

[EPIC] Improve sqlparser performance #1557

alamb opened this issue Nov 26, 2024 · 0 comments

Comments

@alamb
Copy link
Contributor

alamb commented Nov 26, 2024

What problem are you trying to solve?

Normally, in a SQL processing system, parsing SQL is not a major bottleneck compared to actually processing data. That being said, given how many SQL strings are parsed by this crate, I think there is significant benefit to improving the performance of the SQL parser in this crate.

That being said, I also think it is important to minimize the impact on downstream crates as much as possible.

Recently, we started introducing locations into the parser (thanks again @Nyrox!), which we found slows things down a bit (see #1435 (comment)).

Thankfully, I think there is significant room for improvement. As as part of the adding location information, I spent some time profiling and I think there are some obvious ways to improve the performance without impacting downstream crates.

Here is the flamegraph for anyone who is interested (you can download it locally to get zoom / etc):

fixed-flamegraph

fixed-flamegraph

What would you like to see?

The idea would be

  1. Run the benchmarks (instructions in Document micro benchmarks #1555)
  2. Maybe add additional benchmarks so they are more representative
  3. Improve the benchmarks

Ideas to improve performance:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant