Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: platform & plugin prerelease package support #935

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 27, 2024

Platforms affected

n/a

Motivation and Context

  • Support installing plugins to all prerelease identifiers as long as it still satisfies with semver.
  • Improve the warning of installing a prerelease platform for all prerelease identifiers.

Description

  • Use semver to detect if the platform is a prerelease instead of using regular expression against specific tags.
  • Update semver.satisfies to include prerelease version. This allows plugins to install on prerelease platforms as long as the platform's version still satisfies with the minimum version.

Testing

  • cordova platform add
  • cordova plugin add

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.91%. Comparing base (3381125) to head (9e26e62).

Files with missing lines Patch % Lines
src/cordova/platform/addHelper.js 33.33% 2 Missing ⚠️
src/plugman/install.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
- Coverage   87.95%   87.91%   -0.05%     
==========================================
  Files          46       46              
  Lines        2134     2134              
==========================================
- Hits         1877     1876       -1     
- Misses        257      258       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erisu erisu changed the title fix: platform & plugin prelease package support fix: platform & plugin prerelease package support Oct 28, 2024
@erisu erisu merged commit 1bdb0d3 into apache:master Oct 28, 2024
11 checks passed
@erisu erisu deleted the fix/prelease-support branch October 28, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants