Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set the custom icons #251

Open
3 tasks done
Polm90 opened this issue Feb 21, 2023 · 1 comment
Open
3 tasks done

Unable to set the custom icons #251

Polm90 opened this issue Feb 21, 2023 · 1 comment

Comments

@Polm90
Copy link

Polm90 commented Feb 21, 2023

Bug Report

Problem

What is expected to happen?

I want to customize the app icon, avoiding to use the default electron one.

What does actually happen?

Building the app, it says "default Electron icon is used reason=application icon is not set" and it uses the default icons and not the ones I've specified in config.xml file.

Information

Command or Code

Config.xml file:

 <platform name="electron">
    <preference name="ElectronSettingsFilePath" value="res/electron/settings.json"/>
    <preference name="ShowSplashScreen" value="true"/>
    <icon src="res/electron/icons/512x512.png" target="app"/>
    <icon src="res/electron/icons/1024x1024.png" target="installer"/>
  </platform>

Command:
cordova build electron
Note: using cordova run electron --nobuild works, but it's not what i want :)

Build.json:

{
  "electron": {
    "release": {
      "windows": {
        "package": [
          "msi",
          "appx"
        ],
        "arch": [
          "x64"
        ],
        "signing": {
          "release": {
            "certificateFile": "",
            "certificatePassword": ""
          }
        }
      }
    },
    "debug": {
      "windows": {
        "package": [
          "msi","zip"
        ],
        "arch": [
          "x64"
        ],
        "signing": {
          "release": {
            "certificateFile": "",
            "certificatePassword": ""
          }
        }
      }
    }
  }
}

Environment, Platform, Device, Version information

I'm on windows 11.
Cordova: 11.1.0
Cordova-electron: 3.1.0

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
@mbreslein-thd
Copy link

This issue still persists 15 Months later.
Any help with this would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants