cordova run xxx regularly updates package.json with an empty line

[fcamblor]

Bug Report

Problem

Everytime I run cordova run browser, my package.json file is locally updated :

What is expected to happen?

package.json is left unmodified, after any cordova run call (which sounds to be idempotent)

What does actually happen?

A new line is added at the end of package.json

Information

You have a reproducer script below

Command or Code

mkdir /tmp/cordova-sample/ && cd /tmp/cordova-sample/
git init && npm init
npm install --save-dev [email protected]
echo node_modules/ > .gitignore
git add . && git commit -m "initial commit"
npx cordova create tmp-cordova && rm tmp-cordova/package.json && mv tmp-cordova/* ./ && rm -Rf tmp-cordova/
echo platforms >> .gitignore
echo plugins >> .gitignore
git add . && git commit -m "created cordova app"
npx cordova platform add [email protected]
git add . && git commit -m "added browser platform"
# installing a random npm package, resulting in changes in package.json
npm install --save-dev noop
git add . && git commit -m "added no-op package"
# running a cordova run command
npx cordova run browser
# End of line appended at the end of the package.json line
git diff

Environment, Platform, Device

Mac OS X 10.14.4

Version information

Tested on cordova cli 7.1.0, 8.1.2 and 9.0.0
No matter the platform and its version.

Checklist

• I searched for existing GitHub issues
• I updated all Cordova tooling to most recent version
• I included all the necessary information above

[HarelM]

I can confirm this happens to me too.

[fcamblor]

For history, seems a duplicate of #353 and #394 => closing as 353 is the placeholder for this issue

[fcamblor]

BTW, @arzyu seems to have implemented a plugin just for this purpose ( that's crazy x-D )

https://github.com/arzyu/cordova-plugin-package-json-guard

[HarelM]

Totally crazy :-)