Skip to content
This repository has been archived by the owner on Jan 20, 2021. It is now read-only.

Allow changing template type by admin #838

Merged
merged 3 commits into from
Dec 1, 2020

Conversation

ravening
Copy link
Member

@ravening ravening commented Oct 27, 2020

Fixes #835

Currently, the template has the following types:
'BUILTIN', 'USER', 'SYSTEM', 'ROUTING'

Provide ui support for admins os that they can change
the template type

Screenshot 2020-10-27 at 19 10 09

Template type can be seen in template details also

Screenshot 2020-10-27 at 19 10 28

Currently the template has following types:
'BUILTIN', 'USER', 'SYSTEM', 'ROUTING', 'PERHOST'

Provide ui support for admins os that they can change
the template type
@rohityadavcloud
Copy link
Member

Does this depend on any backend API change?

@rohityadavcloud
Copy link
Member

Nevermind - I checked, it does; we may need to wait until the upstream PR is merged at all.

@GabrielBrascher
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@GabrielBrascher a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/838 (JID-3634)

@GabrielBrascher
Copy link
Member

It fails to open the edit popup when trying to edit a template. Tested via http://primate-qa.cloudstack.cloud:8080/client/pr/838.

Can you please check this @ravening?

@ravening
Copy link
Member Author

It fails to open the edit popup when trying to edit a template. Tested via http://primate-qa.cloudstack.cloud:8080/client/pr/838.

Can you please check this @ravening?

@GabrielBrascher do you have the back end change as well?
I tested with having backend change and worked fine. I have attached the screenshot as well

@GabrielBrascher
Copy link
Member

GabrielBrascher commented Oct 29, 2020

Ah ... it got merged yesterday (apache/cloudstack#3945), I see. I will test it later based on the recently merged commit.

@ravening
Copy link
Member Author

It fails to open the edit popup when trying to edit a template. Tested via http://primate-qa.cloudstack.cloud:8080/client/pr/838.
Can you please check this @ravening?

@GabrielBrascher do you have the back end change as well?
I tested with having backend change and worked fine. I have attached the screenshot as well

@GabrielBrascher on a side note, Im curious to know how to have multiple instances on primate running for each pr? is it an automated task? is there a way I can do that on my setup as well? I see that for each pr, there is an endpoint /client/pr/<pr#> . I want to know how to generate new setup like that for each pr

@GabrielBrascher
Copy link
Member

@ravening I have not much idea on the blueoragutan configuration. @rhtyd or @PaulAngus would be able to give some details.

My guess is that this was configured via Jenkins in order to provide the same Mocked infra (hosts, zone, networks, VMs, etc) for all PRs that are tested.

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code and test.

@PaulAngus
Copy link
Member

Blue Orangutan sends build requests to ShapeBlue's internal infra to do builds; So calls to it need to come from ShapeBlue people to protect the infra (and it's easier to shout at them than community members :) ).

We can happily share the actual build process (done via Jenkins).

The medium/long term goal is to have distributed build and test environments across 'donated' central community hardware and private environments, which would be orchestrated from a central location, with some kind of deployment planner.

Internally we know this project as Winston ("I fix things"), and we're going to create it internally which we will then share as a draft blueprint to be taken forward as a community (assuming people want it),

@ravening
Copy link
Member Author

ravening commented Nov 5, 2020

Blue Orangutan sends build requests to ShapeBlue's internal infra to do builds; So calls to it need to come from ShapeBlue people to protect the infra (and it's easier to shout at them than community members :) ).

We can happily share the actual build process (done via Jenkins).

The medium/long term goal is to have distributed build and test environments across 'donated' central community hardware and private environments, which would be orchestrated from a central location, with some kind of deployment planner.

Internally we know this project as Winston ("I fix things"), and we're going to create it internally which we will then share as a draft blueprint to be taken forward as a community (assuming people want it),

@PaulAngus Can you please share the build process and steps so that I will try implementing the same for our internal infrastructure?

@PaulAngus
Copy link
Member

@ravening

I've checked with Rohit regarding the base VM that we use to build primate.

It can be built using any Ubuntu LTS 18.04/20.04 base docker container.

There are build instructions are in the repo's README (https://github.com/apache/cloudstack-primate#getting-started)
These are wrapped up in `https://github.com/apache/cloudstack-primate/blob/master/packaging/package.sh

The overview of installation (again thanks to Rohit) is:

Install nodejs LTS

curl -sL https://deb.nodesource.com/setup_12.x | sudo -E bash -
sudo apt-get install -y nodejs debhelper rpm

Install build tools

npm install -g @vue/cli webpack eslint

In a cloned Primate repo and run package.sh

cd packaging
bash -x package.sh

In the README.md - https://github.com/apache/cloudstack-primate#packaging

@rohityadavcloud rohityadavcloud added this to the 1.0-GA milestone Nov 23, 2020
@rohityadavcloud
Copy link
Member

Looks like related backend PR was merged, should we consider merging this @PaulAngus @DaanHoogland @davidjumani ?

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/838 (JID-3687)

Copy link
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for merging this

@rohityadavcloud rohityadavcloud merged commit 4ce0b40 into apache:master Dec 1, 2020
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
* Allow changing template type by admin

Currently the template has following types:
'BUILTIN', 'USER', 'SYSTEM', 'ROUTING', 'PERHOST'

Provide ui support for admins os that they can change
the template type

* add extr afields

* remove perhost

Co-authored-by: Rakesh Venkatesh <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] server: update template to another template type
6 participants