Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44844: [CI] Uninstall pkg-config entirely on verification and java-jars macOS jobs #44845

Merged
merged 9 commits into from
Nov 26, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Nov 25, 2024

Rationale for this change

Jobs are failing on nightlies.

What changes are included in this PR?

Remove pkg-config entirely as we've done on other CI jobs.

Are these changes tested?

Yes via archery

Are there any user-facing changes?

No

@raulcd
Copy link
Member Author

raulcd commented Nov 25, 2024

@github-actions crossbow submit java-jars verify-rc-macos-

Copy link

⚠️ GitHub issue #44844 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Nov 25, 2024

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Nov 25, 2024

@github-actions crossbow submit java-jars verify-rc-source-macos-

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Nov 25, 2024

@github-actions crossbow submit java-jars

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Nov 25, 2024

@github-actions crossbow submit java-jars verify-rc-source-ruby-macos-amd64

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Nov 25, 2024

@github-actions crossbow submit java-jars

Copy link

Revision: 28bb2ac

Submitted crossbow builds: ursacomputing/crossbow @ actions-15a3eff0b1

Task Status
java-jars GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Nov 25, 2024

@github-actions crossbow submit verify-rc-source-ruby-macos-amd64

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Nov 25, 2024

@github-actions crossbow submit java-jars verify-rc-source-macos-

Copy link

Revision: bac57f0

Submitted crossbow builds: ursacomputing/crossbow @ actions-c40450c19a

Task Status
java-jars GitHub Actions
verify-rc-source-cpp-macos-amd64 GitHub Actions
verify-rc-source-cpp-macos-arm64 GitHub Actions
verify-rc-source-cpp-macos-conda-amd64 GitHub Actions
verify-rc-source-csharp-macos-amd64 GitHub Actions
verify-rc-source-csharp-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-amd64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-conda-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions
verify-rc-source-js-macos-amd64 GitHub Actions
verify-rc-source-js-macos-arm64 GitHub Actions
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions
verify-rc-source-ruby-macos-amd64 GitHub Actions
verify-rc-source-ruby-macos-arm64 GitHub Actions

@raulcd raulcd marked this pull request as ready for review November 25, 2024 16:01
@raulcd
Copy link
Member Author

raulcd commented Nov 25, 2024

@kou the verify-rc-source-ruby-macos-amd64 job is also related to pkg-config when installing meson but I haven't seen other failures on amd64 so I am not entirely sure what is going on on this one.

@kou
Copy link
Member

kou commented Nov 25, 2024

Meson doesn't find pkgconf by default. So we need to specify it explicitly. See also:

@kou
Copy link
Member

kou commented Nov 26, 2024

@github-actions crossbow submit verify-rc-source-ruby-macos-*

Copy link

Revision: d1f5c24

Submitted crossbow builds: ursacomputing/crossbow @ actions-2908659df0

Task Status
verify-rc-source-ruby-macos-amd64 GitHub Actions
verify-rc-source-ruby-macos-arm64 GitHub Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 2e6fe1a into apache:main Nov 26, 2024
7 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Nov 26, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 26, 2024
@raulcd raulcd deleted the GH-44844 branch November 26, 2024 07:35
@raulcd
Copy link
Member Author

raulcd commented Nov 26, 2024

Thanks @kou

Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2e6fe1a.

There were 132 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants