Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Windows.h Capitalization breaks cross-platform build #44754

Closed
evetion opened this issue Nov 17, 2024 · 1 comment
Closed

[C++] Windows.h Capitalization breaks cross-platform build #44754

evetion opened this issue Nov 17, 2024 · 1 comment
Assignees
@evetion
Labels
Component: C++ Type: bug
Milestone
19.0.0

Comments

@evetion
Copy link
Contributor

evetion commented Nov 17, 2024

Describe the bug, including details regarding any error messages, version, and platform.

Over at JuliaPackaging/Yggdrasil#9801, we build Arrow cross-platforms for use in the Julia language.

The capitalization of Windows.h in https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/io_util.cc#L121 breaks the mingw compilation for Windows platforms, as the host platform is case-sensitive, and mingw only provides the lowercased variant:

[15:22:30] /workspace/srcdir/arrow/cpp/src/arrow/util/io_util.cc:121:12: fatal error: Windows.h: No such file or directory
[15:22:30]  #  include <Windows.h>
[15:22:30]             ^~~~~~~~~~~
[15:22:30] compilation terminated.

Component(s)

C++
@evetion evetion changed the title Windows.h Capitalization breaks cross-platform build [C++] Windows.h Capitalization breaks cross-platform build Nov 17, 2024
@evetion evetion mentioned this issue Nov 17, 2024
Merged
kou pushed a commit that referenced this issue Nov 17, 2024
@evetion
GH-44754: [C++] Use lowercased windows.h to enable cross-platform b…
23328ff 
…uilds (#44755)

### Rationale for this change

`<Windows.h>` doesn't work cross-compiling to Windows with case-sensitive file system.

### What changes are included in this PR?

Use lowercase.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #44754

Authored-by: Maarten Pronk <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 19.0.0 milestone Nov 17, 2024
@kou
Copy link
Member

kou commented Nov 17, 2024

Issue resolved by pull request 44755
#44755

@kou kou closed this as completed Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evetion evetion

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
2 participants
@kou @evetion