Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Security issue in JSON dependency #44463

Closed
amol- opened this issue Oct 17, 2024 · 7 comments
Closed

[C#] Security issue in JSON dependency #44463

amol- opened this issue Oct 17, 2024 · 7 comments

Comments

@amol-
Copy link
Member

amol- commented Oct 17, 2024

It seems that C# integration tests have started failing due to a security issue having been reported for System.Text.Json

  /arrow/csharp/test/Apache.Arrow.IntegrationTest/Apache.Arrow.IntegrationTest.csproj : error NU1903: Warning As Error: Package 'System.Text.Json' 8.0.4 has a known high severity vulnerability, https://github.com/advisories/GHSA-8g4q-xg66-9fp4 [/arrow/csharp/Apache.Arrow.sln]

Component(s)

C#

@CurtHagenlocher
Copy link
Contributor

CurtHagenlocher commented Oct 17, 2024

Odd; it's been days since Dependabot has sent a PR for this in the arrow-adbc repo. Maybe it's backed up for Arrow?

This is an easy enough change -- just update to 8.0.5 -- and if no one else does it I'll be able to do it later today.

@raulcd
Copy link
Member

raulcd commented Oct 17, 2024

@CurtHagenlocher is this required for 18.0.0?

@CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher is this required for 18.0.0?

Yes, we should update this for 18.0.0.

@raulcd raulcd added this to the 18.0.0 milestone Oct 17, 2024
@raulcd raulcd added the Priority: Blocker Marks a blocker for the release label Oct 17, 2024
@CurtHagenlocher
Copy link
Contributor

@raulcd I take that back, the dependency in question is used only in test code so it probably doesn't need to be a blocker for 18.0.0.

@raulcd
Copy link
Member

raulcd commented Oct 17, 2024

Thanks, that makes sense. There's a couple more issues found that will make us create a new release candidate.
Let's leave it as 18.0.0 for now and if it's done before those I'll cherry pick it.

@kou kou changed the title Security issue in JSON dependency for C# [C#] Security issue in JSON dependency Oct 17, 2024
@raulcd raulcd added backport-candidate and removed Priority: Blocker Marks a blocker for the release labels Oct 18, 2024
@raulcd raulcd modified the milestones: 18.0.0, 19.0.0 Oct 18, 2024
@CurtHagenlocher
Copy link
Contributor

I should have looked more closely at this yesterday. The warning is not coming on the main branch (which was indeed fixed due to Dependabot) but probably from the release branch? In any event, the PR which addressed this in main was #44343.

@raulcd
Copy link
Member

raulcd commented Oct 18, 2024

Thanks @CurtHagenlocher. I've added the backport-candidate label to the PR. I'll cherry-pick manually if we end up doing a new RC. I close this as completed.

@raulcd raulcd closed this as completed Oct 18, 2024
@assignUser assignUser modified the milestones: 19.0.0, 18.1.0 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants