Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Stop running CI "push" jobs for Dependabot #44404

Closed
kou opened this issue Oct 14, 2024 · 1 comment
Closed

[CI] Stop running CI "push" jobs for Dependabot #44404

kou opened this issue Oct 14, 2024 · 1 comment

Comments

@kou
Copy link
Member

kou commented Oct 14, 2024

Describe the enhancement requested

Dependabot creates a branch for a PR on apache/arrow not a fork repository. So CI jobs for Dependabot PR include "push" jobs and "pull_request" jobs. We can stop these "push" jobs because "push" jobs and "pull_request" jobs are duplicated.

For example: #44399

Component(s)

Continuous Integration

kou added a commit to kou/arrow that referenced this issue Oct 14, 2024
kou added a commit to kou/arrow that referenced this issue Oct 16, 2024
kou added a commit that referenced this issue Oct 17, 2024
### Rationale for this change

They are redundant. We have the same jobs for "push" and "pull_request". We don't need either of them.

### What changes are included in this PR?

Ignore `dependabot/**` branches for "push".

We need to define not only `branches:` but also `tags:`. If we don't define `tags:`, the target workflows aren't trigger by tag push.

See also: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore

> If you define only tags/tags-ignore or only branches/branches-ignore, the workflow won't run for events affecting the undefined Git ref. If you define neither tags/tags-ignore or branches/branches-ignore, the workflow will run for events affecting either branches or tags. If you define both branches/branches-ignore and [paths/paths-ignore](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore), the workflow will only run when both filters are satisfied.

### Are these changes tested?

No. Let's try on apache/arrow main.

### Are there any user-facing changes?

No.
* GitHub Issue: #44404

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou
Copy link
Member Author

kou commented Oct 17, 2024

Issue resolved by pull request 44405
#44405

@kou kou added this to the 19.0.0 milestone Oct 17, 2024
@kou kou closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant