From c9275200081ee8b245c974e0cbe854df5ab1e3c0 Mon Sep 17 00:00:00 2001 From: Joris Van den Bossche Date: Thu, 24 Aug 2023 21:33:17 +0200 Subject: [PATCH] GH-37307: [Python][CI] Manually skip tests with skip_with_pyarrow_strings marker for nightly dask integration tests (#37324) ### Rationale for this change Dask added some tests with a custom `@ pytest.mark.skip_with_pyarrow_strings` mark, which ensures to skip some tests when pyarrow is installed. However, that skip doesn't work correctly when running the tests on an installed version of dask with `pytest --pyargs dask.tests`. Therefore manually skipping tests with that mark as a workaround. * Closes: #37307 Authored-by: Joris Van den Bossche Signed-off-by: Joris Van den Bossche --- ci/scripts/integration_dask.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ci/scripts/integration_dask.sh b/ci/scripts/integration_dask.sh index d1e2ecdc847f2..5b57fb486aa6c 100755 --- a/ci/scripts/integration_dask.sh +++ b/ci/scripts/integration_dask.sh @@ -31,11 +31,13 @@ python -c "import dask.dataframe" # pytest -sv --pyargs dask.bytes.tests.test_hdfs # pytest -sv --pyargs dask.bytes.tests.test_local -pytest -v --pyargs dask.dataframe.tests.test_dataframe +# The "skip_with_pyarrow_strings" marker is meant to skip automatically, but that doesn't work with --pyargs, so de-selecting manually +pytest -v --pyargs dask.dataframe.tests.test_dataframe -m "not skip_with_pyarrow_strings" pytest -v --pyargs dask.dataframe.io.tests.test_orc # skip failing parquet tests # test_pandas_timestamp_overflow_pyarrow is skipped because of GH-33321. pytest -v --pyargs dask.dataframe.io.tests.test_parquet \ - -k "not test_pandas_timestamp_overflow_pyarrow" + -k "not test_pandas_timestamp_overflow_pyarrow" \ + -m "not skip_with_pyarrow_strings and not xfail_with_pyarrow_strings" # this file contains parquet tests that use S3 filesystem pytest -v --pyargs dask.bytes.tests.test_s3