Implement logical_null_count for more array types #6704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Array::logical_null_count() where it's easy to calculate answer without relying on the default implementation which allocates.
|
Please can you stop tagging me on PRs you've filled literally moments ago, it is disruptive and rude. I will get to your PRs within a couple of days, but your incessant nagging is really starting to grate. |
|
I would consider it rude not to tag you on a PR that's on a topic I know you're interested in and knowledgable about. |
Dandandan
approved these changes
Nov 9, 2024
|
FWIW the default implementation doesn't allocate, it just increments a reference count, but this is largely harmless |
findepi
deleted the
findepi/implement-logical-null-count-for-more-array-types-22e389
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
Array::logical_null_count()where it's easy to calculate answer without relying on the default implementation which allocates.Which issue does this PR close?
None
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
No