Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Force static library build on Windows when building with Meson #496

Merged
merged 1 commit into from
May 29, 2024

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented May 28, 2024

May not necessarily fix #495 but reasonably defers trying to solve

Basically the suggestion of the great @eli-schwartz

@paleolimbot paleolimbot changed the title fix: Force static library build on Windows fix: Force static library build on Windows when building with Meson May 29, 2024
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paleolimbot paleolimbot merged commit 8171104 into apache:main May 29, 2024
33 checks passed
@WillAyd WillAyd deleted the meson-windows-compat branch May 29, 2024 00:39
@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export symbols from C library when compiling as a shared library on Windows
2 participants