Simplify asset decorator implementation #44344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since AssetDefinition subclasses Asset, we don't really need the to_asset() method, but can just pass self in. I also moved some imports around to reduce module loading at import time.
uranusjr
force-pushed
the
aset-decorator-simplify
branch
from
f552f8f
to
f4d1a27
Compare
Lee-W
approved these changes
Nov 26, 2024
|
overall looks good, but look like we need to update some test cases 🤔 |
|
Actually that’s a bug in my implementation. Fixed. |
eladkal
approved these changes
Nov 26, 2024
attrs defaults only kick in if we don't provide a value. So we need to be more careful not to provide a thing (instead of providing a default).
uranusjr
force-pushed
the
aset-decorator-simplify
branch
from
7400362
to
217d484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since AssetDefinition subclasses Asset, we don't really need the to_asset() method, but can just pass self in.
I also moved some imports around to reduce module loading at import time.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.