-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mypy to 1.8.0 #36428
Merged
Merged
Upgrade mypy to 1.8.0 #36428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirrao
requested changes
Dec 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some pre commit checks are failing due to version upgrade. May be the new version enforces the strict checks.
hussein-awala
commented
Dec 26, 2023
hussein-awala
force-pushed
the
mypy_1.8.0
branch
from
January 8, 2024 23:36
868acc8
to
42ddd18
Compare
hussein-awala
commented
Feb 7, 2024
potiuk
approved these changes
Feb 7, 2024
Seems it works. |
potiuk
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Feb 12, 2024
potiuk
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Upgrade mypy to 1.8.0 * Type annotation improvements for Mypy 1.8 * Remove unneeded alias * Work around tenacity annotation * workaround for Never not callable * revert the workaround * ignore mypy on _retry_obj --------- Co-authored-by: Tzu-ping Chung <[email protected]> (cherry picked from commit 90e2b12)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Upgrade mypy to 1.8.0 * Type annotation improvements for Mypy 1.8 * Remove unneeded alias * Work around tenacity annotation * workaround for Never not callable * revert the workaround * ignore mypy on _retry_obj --------- Co-authored-by: Tzu-ping Chung <[email protected]> (cherry picked from commit 90e2b12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.