Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the ojph_ prefix. #98

Open
aous72 opened this issue Dec 21, 2022 · 6 comments
Open

Removing the ojph_ prefix. #98

aous72 opened this issue Dec 21, 2022 · 6 comments

Comments

@aous72
Copy link
Owner

aous72 commented Dec 21, 2022

@chafey
It was suggested to me before by you, and perhaps others, that I remove the ojph_ prefix from the files. It makes everything shorter.
It is easy to do.
Are you still of this opinion?

Thank you.

@chafey
Copy link
Contributor

chafey commented Dec 21, 2022

Yes, this would be a good improvement.

@thewtex
Copy link
Contributor

thewtex commented Aug 8, 2023

Hi @aous72 @chafey ,

Thank you for your wonderful work 🙏

Can we please keep the ojph_ prefix to avoid ambiguity with similar files?

@chafey
Copy link
Contributor

chafey commented Aug 8, 2023 via email

@aous72
Copy link
Owner Author

aous72 commented Aug 8, 2023

Good to hear from you @thewtex, and thank you @chafey.

@thewtex
Copy link
Contributor

thewtex commented Aug 9, 2023

I am not sure why a prefix is considered not scalable? We just have a prefix in the file names. A prefix is a best practice and it is used by many libraries including, for example, JPEG, TIFF, and PNG to name a few. Commonly headers are included by name, without including their directory, and the prefix avoids ambiguity. Headers are ideally portable and not tied to a directory structure. For example, the directory structure of headers in the OpenJPH source tree and install tree are different, and one may want to be able to build against one or the other. Or, they may want to vendor the headers in a different directory layout.

@aous72
Copy link
Owner Author

aous72 commented Aug 11, 2023

I would not mind keeping the prefix.
Perhaps, I can remove the prefix from internal files, and keep it for interface files (i.e., those included by other applications).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants