Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing integration modules and broken links in docs #302

Open
seanf opened this issue Aug 24, 2018 · 1 comment
Open

Missing integration modules and broken links in docs #302

seanf opened this issue Aug 24, 2018 · 1 comment

Comments

@seanf
Copy link
Contributor

seanf commented Aug 24, 2018

The website http://cyclops-react.io/ and the readme for https://github.com/aol/cyclops (and its description "Home of the cyclops integration modules : support for Scala, Clojure, RxJava (1+2), Reactor, FunctionalJava, Guava, Dexx & Vavr") refer to several integrations which seem to have been purged.

(*) I think the last two are just broken/outdated links, because I found these:

These two integrations are visible in Maven Central: https://search.maven.org/search?q=g:com.oath.cyclops but were apparently not released as part of 10.0.0-FINAL, only 10.0.0-M7.

Are some or all of the integrations discontinued?

@johnmcclean
Copy link
Member

johnmcclean commented Aug 29, 2018

Hey Sean,

Most of these integrations were in place for cyclops-react 2 (under separate cyclops versioning of 9). In Cyclops 10 Rx2 and Reactor were promoted to core modules and the migration to the new code base has been completed. There were significant API changes between cyclops-react 2 and 10 (with a focus on API safety and making illegal states unrepresentable).

Cyclops 10 also introduces a suite of core functional collections (Vector / ArrayList, Seq / LinkedList, LazySeq / LazyLinkedList etc) which may make some of the integration modules less significant (e.g. Dexx, possibly Scala and Clojure).

I don't envisage significant API changes in Cyclops over the next couple of years, adding back some (or all) of the missing integration modules in a prioritized order over the coming months may make sense. I suspect Vavr and Functional Java would be the most useful ones to start with (open to advice!) - Vavr does seem to be going through a major redesign of it's own at the moment.

The cyclops-react.io website needs to be updated to reflect cyclops X (10) and an archived view of the links and information for legacy cyclops-react 2 should be provided on the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants