From 45a8cc8cc26e10acb324d8c238eef71d4536059c Mon Sep 17 00:00:00 2001
From: Aaron Ogburn <aogburn@redhat.com>
Date: Mon, 12 Oct 2020 14:21:01 -0400
Subject: [PATCH] Add specific findings for EJB strict max pool exhaustion,
 datasource exhaustion, JBoss log write contention, and Array copies.

---
 md5      |  2 +-
 yatda.sh | 26 ++++++++++++++++++++++++++
 2 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/md5 b/md5
index 0fab61f..376529e 100644
--- a/md5
+++ b/md5
@@ -1 +1 @@
-1c19a67e8c8b8b69df10183908a813e7
+e69057e8b81689a4c9e8a3e4cfc34a64
diff --git a/yatda.sh b/yatda.sh
index d3a162a..4ba02ea 100755
--- a/yatda.sh
+++ b/yatda.sh
@@ -145,10 +145,36 @@ if [ $REQUEST_COUNT -gt 0 ] && [ $REQUEST_COUNT == $REQUEST_THREAD_COUNT ]; then
 fi
 
 
+# check EJB strict max pool exhaustion
+COUNT=`grep "at org.jboss.as.ejb3.pool.strictmax.StrictMaxPool.get" $FILE_NAME | wc -l`
+if [ $COUNT -gt 0 ]; then
+    echo >> $FILE_NAME.yatda
+    echo $((i++)) ": The amount of threads waiting for an EJB instance in org.jboss.as.ejb3.pool.strictmax.StrictMaxPool.get is $COUNT.  This indicates an EJB instance pool needs to be increased for the load (https://access.redhat.com/solutions/255033).  Check other threads actively processing in org.jboss.as.ejb3.component.pool.PooledInstanceInterceptor.processInvocation to see if EJB instances are used up in any specific calls." >> $FILE_NAME.yatda
+fi
+
+
 # check datasource exhaustion
+COUNT=`grep "at org.jboss.jca.core.connectionmanager.pool.api.Semaphore.tryAcquire" $FILE_NAME | wc -l`
+if [ $COUNT -gt 0 ]; then
+    echo >> $FILE_NAME.yatda
+    echo $((i++)) ": The amount of threads waiting for a datasource connection in org.jboss.jca.core.connectionmanager.pool.api.Semaphore.tryAcquire is $COUNT.  This indicates a datasource pool needs to be increased for the load or connections are being leaked or used too long (https://access.redhat.com/solutions/17782)." >> $FILE_NAME.yatda
+fi
+
+
+# check log contention
+COUNT=`grep "at org.jboss.logmanager.handlers.WriterHandler.doPublish" $FILE_NAME | wc -l`
+if [ $COUNT -gt 0 ]; then
+    echo >> $FILE_NAME.yatda
+    echo $((i++)) ": The amount of threads in org.jboss.logmanager.handlers.WriterHandler.doPublish is $COUNT.  High amounts of threads here may indicate logging that is too verbose and/or log writes that are too slow.  Consider decreasing log verbosity or configure an async log handler (https://access.redhat.com/solutions/444033) to limit response time impacts from log writes." >> $FILE_NAME.yatda
+fi
 
 
 # check java.util.Arrays.copyOf calls
+COUNT=`grep "at java.util.Arrays.copyOf" $FILE_NAME | wc -l`
+if [ $COUNT -gt 0 ]; then
+    echo >> $FILE_NAME.yatda
+    echo $((i++)) ": The amount of threads in java.util.Arrays.copyOf is $COUNT.  Notable amounts of threads here or a significant time spent here in any thread may indicate a lot of time blocked in safe point pausing for GC because of little free heap space or the Array copies and other activity generating excessive amounts of temporary heap garbage.  GC logs should be reviewed to confirm or rule out GC performance concerns." >> $FILE_NAME.yatda
+fi
 
 echo >> $FILE_NAME.yatda
 # end Findings