-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TransportRaceCondition is not found becasue it is renamed to TransportPendingOperation #949
Conversation
If this is a fix can it be merged already? 🤲🙏 |
How to solve this problem? |
Adding this to your package.json is a work around. "overrides": { |
I tried using that version, but I'm still encountering the same error.
|
I'm using yarn and added resolutions but not working. |
I have the same problem. Have you found a solution? |
Still does not work . . . |
Still does not work . . . |
AND
doesn't work, or I get missing modules:
These modules aren't missing when I use yarn. I am trying to get this working: https://github.com/anza-xyz/wallet-adapter/tree/master/packages/starter/create-react-app-starter Edit: Also I need to add "@ledgerhq/errors": "6.16.3" to my dependencies too right? |
npm -i force ❌ npm i --force ✅ |
npm i --force results in:
pnpm i --force results in:
I am trying to get this working: https://github.com/anza-xyz/wallet-adapter/tree/master/packages/starter/create-react-app-starter. I have been trying to get this to work for the past 10 days. I had a smooth time cross compiling the Solana program into bytecode, but I am really struggling on the frontend side. The react template is completely broken and the person who renamed TransportRaceCondition did not help. Do you have any solution? If not then I am thinking of using Yarn because it actually installs the missing dependencies instead of skipping them and then going into transport.js and changing the function being called from TransportRaceCondition to TransportPendingOperation. What do you think? |
I am still getting the error:
Even if I replace the TransportRaceCondition import as TransportPendingOperation in transport.js. Not sure what I am missing here. |
Hmmm I have been digging deeper. I renamed TransportRaceCondition to TransportPendingOperation in both transport.js, transport.ts, and transport.js.flow and everywhere it is associated in @LedgerHQ and I am still having this compile error. Why does it keep giving me this error even though I changed the function call? |
@Kori000 I am having the same problem as @gameuser1982 and others. Can you possibly assist? What kind of god damned idiot decided to rename TransportRaceCondition to TransportPendingOperation? It creates so much trouble! |
For temporarily fix, add below line into file
|
This seems to be a monorepo issue. If you want to use If you're using Vite, here's a Vite template I've created that works with both npm and pnpm. However, using yarn may cause some issues, which I'll address below. |
Regarding this Vite template, yarn v1 only accepts resolutions instead of overrides. When I added the following to package.json: "resolutions": {
"@ledgerhq/errors": "6.16.3"
} After removing node_modules and any lock files, and completing yarn install, starting the project still throws the following error: export 'TransportRaceCondition' (imported as 'TransportRaceCondition') was not found in '@ledgerhq/errors' When I removed the resolutions section from package.json and ran yarn install again, the project ran successfully. This is a peculiar issue, so I suggest using npm, pnpm, or bun as package managers. If someone can resolve this issue with yarn, then I'd recommend using yarn." |
Is there any ETA for this fix to be reviewed and approved for merger if it successfully passes? |
seriously, FIX THIS |
I'm getting the same problem, and already try did all the steps here. I'm writing to update the community still had the issue.
|
This ended up working as a temp fix Just .... wow. I got nothing good to say ... Incompetent |
Any updates on this... huge headache for the past 4 weeks this has been |
Merged and updated the lockfile in 8748ff5. Please let me know if this fixes the issue for you! |
@jordaaash I still get this error. I've installed the latest version and it's 0.19.32. Is this version involved your updates? |
@fulldev100 can you link to a repo with code where you have the issue? We can't see from the screenshot where it occurs. |
@linuxhjkaru Working as a temporary fix for now. Thankyou so much for your help. |
it occurs as soon as i write if i comment this line, everything works fine |
ok this worked for me
But still Please fix this issue ASAP! so i can use it with yarn without any errors |
@sponge-babe Please can you provide a repo demonstrating this issue? We haven't been able to reproduce it and we're not sure why you and others are seeing it and we're not. I've created a new NextJS app using only npm, added wallet-adapter and the Ledger wallet (using Here's my repo, with step-by-step instructions of what I did: https://github.com/mcintyre94/wallet-adapter-ledger-test And here's a deployed version where you should be able to connect a ledger wallet (all it has is the multi button): https://ledger-test-grecdvccf-callum-mcintyres-projects.vercel.app We'd like to help understand and fix this issue, but we need a repo where it's happening because we can't reproduce it ourselves. |
There you go @mcintyre94 , Ledger-hq-issue-repo |
Thanks, I can repro with Moving discussion to #950 (comment) which is an open issue instead of this closed PR |
I got a new error in the browser
|
This comment was marked as resolved.
This comment was marked as resolved.
Thanks, everyone. Please move relevant discussion to #950. |
LedgerHQ/ledger-live@931d511
Expaned view