-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransportRaceCondition in ledger-transport.js changed to TransportPendingOperation #950
Comments
Hey. noticed this issue also. So it uses the previous working version, pending the time this is resolved |
Hey @jesulonimii , thanks a lot for the help... it saved me |
Getting same error but enable to resolve. |
@jesulonimii A better way is to add overrides in the package.json file of your project. #949 |
Can you share the exact change here? |
after down grade the version it throws another error:
|
Can someone please provide source code that produces an error here? I've updated the example app to include I'd like to understand this error more before figuring out how we want to fix it here. Also note that |
I'm going to move discussion here from #949 which is a closed PR Thanks to https://github.com/sponge-babe we have a repro using yarn: https://github.com/sponge-babe/ledgerhq-issue I can repro with If I add resolutions like this:
Then there's a warning from
But it does seem to resolve to 6.16.3:
But I still get the error when it starts:
Now if I search
If I instead add the resolution:
Then that fixes the issue. So as a workaround for everyone seeing this, this resolution is probably the best solution. I'm a bit stumped though, because we have that resolution: Line 63 in 8748ff5
We also have that precise version as the dependency of the ledger adapter:
So I'm not sure how yarn is messing this up TBH, or what we can do to fix this for you in our code. I'm not really familiar with yarn though, so would be keen to hear any ideas. Also, has anyone seen this with any package manager other than Yarn? |
i tried your solution in the same repo, and it didn't work. how did you make it work with: |
I've managed to find a workaround fix based on previous suggestions, which is currently working with pnpm, & yarn. There are no issues with Vite either. I'm using React v18.2.0. Adding the following seems to be working at the moment :
|
This solution worked! Thanks @TechTronixx |
It seems some small tweaking is needed for npm as
|
Error: No matching export in "node_modules/@ledgerhq/errors/lib-es/index.js" for import "TransportRaceCondition"
which is causing the application to break on running "npm run dev",
because TransportRaceCondition has been updated to TransportPendingOperation, as mentioned here LedgerHQ/ledger-live@931d511
swapping TransportRaceCondition with TransportPendingOperation in the node modules worked for me, but it might break the application in production.
The text was updated successfully, but these errors were encountered: