Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen doesn't open wallets #784

Open
CalvinMaighan opened this issue Jun 3, 2023 · 3 comments
Open

Fullscreen doesn't open wallets #784

CalvinMaighan opened this issue Jun 3, 2023 · 3 comments

Comments

@CalvinMaighan
Copy link

  • When you are in fullscreen on a mac (I always code in fullscreen splitting between my editor and chrome) and click on a wallet (I've tested with Phantom) it does not open until you exit fullscreen and it shows nothing to the user suggesting to close fullscreen. Ideally there would be a way to not have to close fullscreen every time you want to sign something.
@jordaaash
Copy link
Collaborator

This sounds like an OS / browser / extension issue. If the behavior is consistent across several browser extension wallets, it's probably not something they can change. This certainly isn't a limitation of Wallet Adapter, so I'm closing this issue.

@jordaaash jordaaash reopened this Jun 22, 2023
@jordaaash
Copy link
Collaborator

Oh, I see. You're saying that the app should warn the user that they are in fullscreen, or try to exit fullscreen, so that the extension will open? Sounds tricky to get right, but I'll leave this open to consider.

@mcintyre94
Copy link
Collaborator

I can't repro this on macOS/Chrome fullscreen. For Glow, Backpack and Phantom on the example app I get switched to the wallet UI:

Screen.Recording.2023-06-22.at.14.33.20.mov

Not an ideal UX but I'm not seeing this bug where it doesn't open the wallet

Which browser and app are you seeing this on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants