Fixing dynamic fields #71
Conversation
| let dump = ll_sty.dump_to_string(); | ||
| debug!(target: "debug", "Dumping translated structure {ll_name} {}", dump); | ||
| assert!(!self.llvm_cx.named_struct_type(&ll_name).is_none(), "At this point struct {} should already get some type", &ll_name); | ||
| ll_sty |
| @@ -128,7 +128,8 @@ impl<'up> GlobalContext<'up> { | |||
| #[cfg(feature = "solana")] | |||
| assert!(account_address::AccountAddress::ZERO.len() == 32); | |||
|
|
|||
| debug!(target: "globalenv", "{:#?}", env); | |||
| // Note: printing global env genarates huge output, but you can do it with the following line | |||
| // debug!(target: "globalenv", "{:#?}", env); | |||
There was a problem hiding this comment.
We should just remove this line. Anyone can add debug if they want to inspect.
There was a problem hiding this comment.
This comment points to the exact place where printing this info is the most useful (but really bulky).
I do not want to investigate next time I debug compiler where would be the best place for this line. So that is why I left this comment.
There was a problem hiding this comment.
That's why we have a way to specify target: keys no? we can leave this uncommented with a specific target key. https://docs.rs/tracing/0.1.37/tracing/index.html#for-log-users
There was a problem hiding this comment.
If you look at your next comment you'll see that this debug! is operated by "nodes", but it will be printed for target "debug" as well. And I need target debug while debugging...
But any way, I do not fight for this minor issue, this PR does not worth it. I'll just keep this code unchanged.
| .get_nodes() | ||
| .iter() | ||
| .map(|nd| (*nd, g_env.get_node_type(*nd))) | ||
| .collect(); | ||
| debug!(target: "nodes", "\n{:#?}", &map_node_to_type); | ||
| // NOTE. Printing nodes is reserved for the future development of compiler | ||
| // debug!(target: "nodes", "\n{:#?}", &_map_node_to_type); |
There was a problem hiding this comment.
Same here. Let's delete this line.
| @@ -665,6 +673,13 @@ impl<'mm, 'up> FunctionContext<'mm, 'up> { | |||
| .into_struct(*struct_id); | |||
| assert_eq!(dst.len(), 1); | |||
| assert_eq!(src.len(), senv.get_field_count()); | |||
| let s_full_name = senv.get_full_name_str(); | |||
There was a problem hiding this comment.
We should outline this code in a separate function as this is solely for debugging.
There was a problem hiding this comment.
I did not understand this comment. Please explain.
There was a problem hiding this comment.
sorry for the typo. lines 676-682 seems to be used only for debugging purposes. we can outline this to a separate function.
There was a problem hiding this comment.
Ok, adding a printing fields function for StructEnv.
|
This PR was superseded by #73. Closing it without merge. |
Added test
dynamic-struct-example.moveexplains the problem:The solution is to instantiate this structure right in the instantiation of the generic function.
Note. The key change in this PR is in added
elsecase in module_context.rs:734.See more in #72