Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept password hash in config #135

Open
b12f opened this issue Apr 30, 2022 · 3 comments
Open

Accept password hash in config #135

b12f opened this issue Apr 30, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@b12f
Copy link

b12f commented Apr 30, 2022

It'd be great if the config file would accept password hashes, so the config can be put in a public repository without compromising the secret.

@quite
Copy link

quite commented May 28, 2022

I must say that placing even hashed passwords in the public doesn't seem like a great idea.

@b12f
Copy link
Author

b12f commented May 28, 2022

A password that's hashed with bcrypt with enough rounds is fine to be published, afaik.

My usecase is the following; we're creating a NixOS configuration and I'd like wayvnc to be available by just enabling one config option. Currently, we take in one password hash for a user, and then just apply that hash everywhere appropriate.

https://git.b12f.io/pub-solar/os/src/commit/e10f27785498a10cfc22de8c89f76defa98c4599/users/ben/default.nix#L22
https://git.b12f.io/pub-solar/os/src/commit/e10f27785498a10cfc22de8c89f76defa98c4599/profiles/base-user/default.nix#L26

@any1 any1 added enhancement New feature or request good first issue Good for newcomers labels Jan 15, 2023
@any1
Copy link
Owner

any1 commented Jan 15, 2023

If someone decides to implement this, please use a strong hashing algorithm by today's standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants