Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.1 won't build against ffmpeg 7.1 #121

Open
alucryd opened this issue Oct 3, 2024 · 3 comments
Open

0.8.1 won't build against ffmpeg 7.1 #121

alucryd opened this issue Oct 3, 2024 · 3 comments
Milestone

Comments

@alucryd
Copy link

alucryd commented Oct 3, 2024

New ffmpeg release has moved a struct member: FFmpeg/FFmpeg@7f17e0e

Building 0.8.1 against the new ffmpeg results in the following error:

../neatvnc/src/h264-encoder.c: In function ‘h264_encoder_create’:
../neatvnc/src/h264-encoder.c:550:58: error: ‘AVFilterLink’ has no member named ‘hw_frames_ctx’
  550 |                 av_buffer_ref(self->filter_out->inputs[0]->hw_frames_ctx);
      |                                                          ^~
@any1
Copy link
Owner

any1 commented Oct 3, 2024

Thanks for the heads-up.

We're abusing a "private" API for this, but there's really no other way to get at this. Maybe I can allocate my own hw_frames_ctx and put it there.

@any1
Copy link
Owner

any1 commented Oct 3, 2024

Huh, looks like they may have added a function for it called av_buffersink_get_hw_frames_ctx.

@any1
Copy link
Owner

any1 commented Oct 3, 2024

Should be fixed now; haven't built against 7.1 though.

@any1 any1 added this to the v0.9.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants