Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak did test to make it easier to write validation tests #158

Open
itamarst opened this issue Nov 2, 2022 · 0 comments
Open

Tweak did test to make it easier to write validation tests #158

itamarst opened this issue Nov 2, 2022 · 0 comments
Assignees
Labels
Milestone

Comments

@itamarst
Copy link
Contributor

itamarst commented Nov 2, 2022

It would be nice to have a test that generalizes and simplifies the did test, where given a particular directory structure of CDDL/valid CBOR/invalid CBOR it does validations and ensures they succeed/fail respectively.

Hardcoding bad file names, in particular, doesn't scale.

E.g. one could have files to validate that start with either "good-" or "bad-":

tests/fixtures/did/
    example1/
        schema.cddl
        good-empty.cbor
        good-multiple-items.cbor
        bad-not-a-list.cbor

(Also it's unclear to me what did stands for?)

@anweiss anweiss self-assigned this Nov 2, 2022
@anweiss anweiss added the testing label Nov 2, 2022
@anweiss anweiss added this to the v1.0.0 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants