Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Script attachment options: HTML Attribute Names Not Recognized as Case-Sensitive #301

Open
dcastillogi opened this issue May 2, 2023 · 0 comments

Comments

@dcastillogi
Copy link

I've been working with your library and I noticed an issue regarding the "boundsPadding" or any other attribute using camelCase in HTML Script attachment. In my case, I need to use the "boundsPadding" attribute, which is not recognized as case-sensitive in the browser. This causes the attribute to be displayed as "boundspadding" in the browser, which results in JavaScript not recognizing it when trying to access the attribute using dot notation.

Additionally, the library does not recognize "bounds-padding" or "boundspadding" as valid options to set the bounds padding attribute. This further limits the options for users to set the attribute correctly.

Example:

<script src='https://unpkg.com/[email protected]/dist/panzoom.min.js' query='#scene' name='pz' pz-bounds='true'
        pz-autocenter='true' pz-boundsPadding="0.9"></script>

While the "bounds" and "autocenter" attributes are successfully applied to the panzoom, the "boundsPadding" attribute is currently being ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant