Building error on Ubuntu 16.04, octave 5.1.0

[bagustris]

I just follow the doc/build.txt and got the following error on step make.

...
/tmp/octaudio-octaudio-1.0.0/src/OcaAudioController.cpp:905:39: error: ‘isfinite’ was not declared in this scope
       if( isfinite( m_recordingCursor ) && ( ! m_duplexStopRequested ) ) {
                                       ^
/tmp/octaudio-octaudio-1.0.0/src/OcaAudioController.cpp:905:39: note: suggested alternative:
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qmath.h:43:0,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:66,
                 from /tmp/octaudio-octaudio-1.0.0/src/OcaAudioController.cpp:26:
/usr/include/c++/5/cmath:844:5: note:   ‘std::isfinite’
     isfinite(_Tp __f)
     ^
CMakeFiles/octaudio.dir/build.make:781: recipe for target 'CMakeFiles/octaudio.dir/src/OcaAudioController.cpp.o' failed
make[2]: *** [CMakeFiles/octaudio.dir/src/OcaAudioController.cpp.o] Error 1
make[2]: Leaving directory '/tmp/octaudio-octaudio-1.0.0'
CMakeFiles/Makefile2:102: recipe for target 'CMakeFiles/octaudio.dir/all' failed
make[1]: *** [CMakeFiles/octaudio.dir/all] Error 2
make[1]: Leaving directory '/tmp/octaudio-octaudio-1.0.0'
Makefile:130: recipe for target 'all' failed
make: *** [all] Error 2

Previously I got error on cmake step about OCTAVE_HDF5_INCLUDE_DIR. After setting it to /usr/local/include/octave-5.1.0/octave/ it works.

Any idea to resolve the problem? I installed qt5 from Ubuntu repo.

[antonrunov]

Try to replace isfinite with std::isfinite. I made a bunch of similar changes in 712425a, but it seems like not all occurrences were corrected.

[antonrunov]

I believe 4f49f59 should build without issues on Ubuntu 16.04, 18.04 and 18.10. I haven't tested it with Octave 5, but it should probably be OK too, because there were no essential changes in Octave APIs between 4.4.1 and 5.1.0. If you have a chance to try it, please let me know the outcome.