Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle and parse error #40

Open
saynb opened this issue Aug 30, 2023 · 2 comments
Open

Handle and parse error #40

saynb opened this issue Aug 30, 2023 · 2 comments

Comments

@saynb
Copy link

saynb commented Aug 30, 2023

Only the top level error is handled today. We need a way to be able to parse the individual update errors in a batch

@saynb
Copy link
Author

saynb commented Aug 30, 2023

@antoninbas Any insight on this ?

@antoninbas
Copy link
Owner

That sounds like the right thing to do.
At the moment, we call the Write RPC and return the error from the gRPC as is:

_, err := c.Write(ctx, req)
return err

We should probably extract the inner errors and return a custom Golang error type which is more user-friendly.
Feel free to take a stab at this if you have some cycles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants