Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform_docsfails with invalid command code R #703

Closed
cschroer opened this issue Aug 29, 2024 · 1 comment · Fixed by #704
Closed

terraform_docsfails with invalid command code R #703

cschroer opened this issue Aug 29, 2024 · 1 comment · Fixed by #704

Comments

@cschroer
Copy link
Contributor

Describe the bug

In PR #701, the usage of sed was introduced to the terraform_docs for in-file changes.

MacOS requires an extension for the -i parameter, unlike GNU sed.
As a result the hook fails on MacOS know with the following error:

Terraform docs..........................................................................Failed
- hook id: terraform_docs
- exit code: 1

sed: 1: "README.md": invalid command code R

How can we reproduce it?

Use MacOS to run the terraform_docs hook.

Environment information

  • OS: MacOS
  • Darwin MB-PRO.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:04 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6020 arm64
@yermulnik
Copy link
Collaborator

yermulnik commented Aug 29, 2024

@cschroer Thanks for catching this. I requested changes in PR of yours (#704) to simplify solution and make it "compatible" on both GNU and POSIX sed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@yermulnik @cschroer @MaxymVlasov and others