Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: backwards compatible way to drop the CR #39

Open
tmccombs opened this issue May 1, 2020 · 0 comments
Open

Idea: backwards compatible way to drop the CR #39

tmccombs opened this issue May 1, 2020 · 0 comments

Comments

@tmccombs
Copy link

tmccombs commented May 1, 2020

What if the initial HELLO message could either end with CRLF or just a single LF, and which one is used determines wether the rest of the connection will use CRLF or LF as a line break. This way clients could continue using CRLF if that is simpler, or switch to just using LF with RESP3 if desired. The biggest downside is that it makes the server code slightly more complicated, and such functionality would probably only be used by RESP3-only clients.

I'm not saying this should necessarily be done, but if removing the unnecessary carriage return is desirable, this could be a way to do it.

All in all the saving of one byte did not made enough sense in light of a more complex client implementation

I'm curious if there is any data on what the actual overhead of the carriage return is on real-world connections. If the bulk of messages are sufficiently small, one byte could make a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant