Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests #17

Open
bsdlp opened this issue Jul 27, 2014 · 8 comments
Open

tests #17

bsdlp opened this issue Jul 27, 2014 · 8 comments

Comments

@bsdlp
Copy link
Collaborator

bsdlp commented Jul 27, 2014

things that need testing:

  • config loading
  • messaging actions
  • handling commands
  • correctly queuing
  • correctly collection votes
@bsdlp
Copy link
Collaborator Author

bsdlp commented Jul 28, 2014

@anthonynguyen
Copy link
Owner

New Partial Done Todo
x config loading
x messaging actions
x handling commands
x correctly queuing
x correctly collection votes

@anthonynguyen
Copy link
Owner

I'll update the table later

@alexanderkress
Copy link

shall your software support only python 3.x?
so python 2.7 will not be supported?

back-to-topic: the config,json file is gone... i assume at the moment the work in progress is too heavy to validate code... i figured out >60 issues...

you should really follow a code style like pep8 described here:
http://legacy.python.org/dev/peps/pep-0008/

@bsdlp
Copy link
Collaborator Author

bsdlp commented Jul 28, 2014

I've been running pep8 on the code since the beginning already. It's also trivial to add pep8 to the testing suite.

@bsdlp
Copy link
Collaborator Author

bsdlp commented Jul 29, 2014

@urthub this runs on py3 currently, py2 has not been tested (except for @Ballsnack confirming it doesn't work 😄). It's up to @ClearSkies but I don't really see the point in adding py2 support.

@anthonynguyen
Copy link
Owner

@urthub I've tested it with 2.7.6 and it runs fine. If you follow the instructions in the README, you should have no problems.

@bsdlp
Copy link
Collaborator Author

bsdlp commented Jul 29, 2014

@urthub I added automated pep8 testing in daf52c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants