-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serverlink uses a PORT file #45
Comments
Ideally, both the client and server find the port in the same file, so that they'll always be in sync. |
But hardcoding on both end works too. The client/server divide for 6bin is just a sad necessity. |
Yep, it was in a unique file before, but we changed it to be a parameter of the server... Guess ill just change it back. Thx |
Why doesn't the client just read it via |
Because it's the first time i've heard of it :p |
This is so very wrong, the port is now passed to the server as parameter through 6brain. It works for now because the
PORT.js
file still exists due to previous versions (wasn't deleted), and because we haven't changed the port. But this might be a problem in the future.https://github.com/anthill/6bin/blob/master/ts/client/serverLink.ts#L8
We might need to go back to hardcoding the
PORT
for everybody, not passing it as a parameter.The text was updated successfully, but these errors were encountered: