Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverlink uses a PORT file #45

Open
bleucitron opened this issue Mar 14, 2016 · 5 comments
Open

Serverlink uses a PORT file #45

bleucitron opened this issue Mar 14, 2016 · 5 comments

Comments

@bleucitron
Copy link
Contributor

This is so very wrong, the port is now passed to the server as parameter through 6brain. It works for now because the PORT.js file still exists due to previous versions (wasn't deleted), and because we haven't changed the port. But this might be a problem in the future.

https://github.com/anthill/6bin/blob/master/ts/client/serverLink.ts#L8

We might need to go back to hardcoding the PORT for everybody, not passing it as a parameter.

@DavidBruant
Copy link
Contributor

Ideally, both the client and server find the port in the same file, so that they'll always be in sync.

@DavidBruant
Copy link
Contributor

But hardcoding on both end works too. The client/server divide for 6bin is just a sad necessity.

@bleucitron
Copy link
Contributor Author

Yep, it was in a unique file before, but we changed it to be a parameter of the server... Guess ill just change it back. Thx

@DavidBruant
Copy link
Contributor

Why doesn't the client just read it via location.port?

@bleucitron
Copy link
Contributor Author

Because it's the first time i've heard of it :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants