FIX: Modified return statement for sweep_around_axis and sweep_along_path so methods accept lists without creating error messages in AEDT. #5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so methods accept lists without creating error messages in AEDT.
2 tasks
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
DaveTwyman
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5416 +/- ##
==========================================
- Coverage 84.39% 84.38% -0.01%
==========================================
Files 140 140
Lines 58645 58655 +10
==========================================
+ Hits 49493 49496 +3
- Misses 9152 9159 +7 |
DaveTwyman
changed the title
SMoraisAnsys
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Greath @DaveTwyman this will solve the bug when users pass a list as input!
Could you add tests to ensure that everything works fine ?
Comment on lines
+3217
to
+3220
| updated_obj = [] | ||
| for sel_obj in assignment: | ||
| updated_obj.append(self.update_object(sel_obj)) | ||
| return updated_obj |
There was a problem hiding this comment.
Suggested change
| updated_obj = [] | |
| for sel_obj in assignment: | |
| updated_obj.append(self.update_object(sel_obj)) | |
| return updated_obj | |
| res = [] | |
| for sel_obj in assignment: | |
| res.append(self.update_object(sel_obj)) | |
| return res |
Just a minor refactor to use a "standard" name for return value.
Comment on lines
+3272
to
+3276
| if isinstance(assignment, list): | ||
| updated_obj = [] | ||
| for sel_obj in assignment: | ||
| updated_obj.append(self.update_object(sel_obj)) | ||
| return updated_obj |
There was a problem hiding this comment.
Suggested change
| if isinstance(assignment, list): | |
| updated_obj = [] | |
| for sel_obj in assignment: | |
| updated_obj.append(self.update_object(sel_obj)) | |
| return updated_obj | |
| if isinstance(assignment, list): | |
| res = [] | |
| for sel_obj in assignment: | |
| res.append(self.update_object(sel_obj)) | |
| return res |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.