Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config file in proj dirrectory #4143

Closed
wants to merge 2 commits into from

Conversation

erichoog
Copy link

@erichoog erichoog commented Feb 28, 2024

This resolves the issue raised in Issue #4142 where Molecule does not find the config.yml file the project directory {project_dir}/.config/molecule/config.yml but does find it in the home directory.

I ran tests by isolating the 2 functions being called when LOCAL_CONFIG variable is defined and verifying that the config file is found when in the project dir. If there is no {project_dir}/.config/molecule/config.yml then it looks in ~/.config/molecule/config.yml and finds the config file.

I have not been able to test the full project with the tox command as my environment is having issues. The tox tests are not completing even on a freshly cloned repo.

The code in the find_vcs_root function could likely be modified more as it does not appear to be called elsewhere and it searches for ".git", ".hg", ".svn" dirs as well for what appears to be no reason as far as I can tell since it is only used for locating .config/molecule/config.yml

Let me know if anything can be improved upon here with my delivery of this as it is my first PR with the project.

Fixes: #4142

@erichoog erichoog requested a review from a team as a code owner February 28, 2024 23:32
@ssbarnea ssbarnea added the bug label Mar 12, 2024
@ssbarnea ssbarnea changed the title Fix #4142 - config file in proj dir Fix config file in proj dirrectory Mar 12, 2024
@ssbarnea
Copy link
Member

ssbarnea commented Aug 1, 2024

Closed due to being abandoned.

@ssbarnea ssbarnea closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Molecule config file in {project}/.config/molecule/config.yml not found
3 participants