Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDAP support. #96

Open
Denney-tech opened this issue Apr 4, 2024 · 2 comments
Open

Add LDAP support. #96

Denney-tech opened this issue Apr 4, 2024 · 2 comments

Comments

@Denney-tech
Copy link

Denney-tech commented Apr 4, 2024

Is your feature request related to a problem? Please describe.
Please add ldap support. The spec.ldap.config CRD from the old pulp resource type is completely ignored in the new operator. In theory, all of the requisite values can be added in pulp_settings:, but there's some problems with values being treated as strings instead of dictionaries or methods.

E.g.

spec:
  pulp_settings:
    auth_ldap_group_type: NestedActiveDirectoryGroupType()

Expected value:
AUTH_LDAP_GROUP_TYPE = NestedActiveDirectoryGroupType()

Actual value:
AUTH_LDAP_GROUP_TYPE = "NestedActiveDirectoryGroupType()"

Since this is being injected into settings.py, it's very important that this is not quoted and treated as string.

Describe the solution you'd like
I like the way ldap_password_secret: and extra_settings: work in AWX-Operator better than in the Pulp-Operator. I've had better luck with setting all the right values there.

Need documentation as well.

Describe alternatives you've considered
Pulp-operator "works" for me, but just barely.

Additional context
I just want Galaxy to play nicely with AD.

@Denney-tech
Copy link
Author

Denney-tech commented Apr 8, 2024

#98 fixes AUTH_LDAP_GROUP_TYPE = NestedActiveDirectoryGroupType() specifically, but it would still be preferred to have an ldap secret to apply the ldap password to.

@josemgom
Copy link

josemgom commented Apr 9, 2024

Agree. It would be better if we have a way to define the password in a secret, that would open the door to use something like sealed secrets to store it in git repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants