-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot add GALAXY_FEATURE_FLAGS to galaxy CR #139
Comments
I suggest we change in the CSV the GALAXY_FEATURE_FLAGS to have x-kubernetes-preserve-unknown-fields and remove execution_environments from being only boolean in the properties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
galaxy-operator: 2024.5.8
Describe the bug
When creating a galaxy CR, you cannot set the GALAXY_FEATURE_FLAGS, because the CR only specifies execution_environments. Plus, the execution_environments can only be boolean, which makes the "True" values become "true". This also causes an error, because the pulp_settings can only understand "True".
https://github.com/ansible/galaxy-operator/blob/5eef56db4a5f8388f69de0d17d160e91692717b9/config/crd/bases/galaxy_v1beta1_galaxy_crd.yaml#L64C15-L74C33
To Reproduce
Create Galaxy CR as following:
Expected behavior
The signatures_enabled will remain in the Galaxy CR, and the execution_environments will allow string.
The text was updated successfully, but these errors were encountered: