Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please enable test_parser_templates.yaml as part of CI #98

Closed
LukeDRussell opened this issue Feb 6, 2019 · 0 comments
Closed

Please enable test_parser_templates.yaml as part of CI #98

LukeDRussell opened this issue Feb 6, 2019 · 0 comments
Assignees
@pabelanger

Comments

@LukeDRussell
Copy link
Contributor

As far as I can tell none of the parsers are being tested as part of CI. When I manually run the tests I am getting assert errors from parsers that have already been merged to devel. It's a bit painful to deal with.

I also suspect #91 will be observed when the parser tests are enabled.
pabelanger added a commit to pabelanger/cisco_ios that referenced this issue Feb 6, 2019
@pabelanger
Add tox test to validate parser
dfbdea0 
We have an existing test_parser_templates.yaml playbook, lets run it on
every commit to increase our coverage.

Closes: ansible-network#98
Signed-off-by: Paul Belanger <[email protected]>
@pabelanger pabelanger mentioned this issue Feb 6, 2019
Merged
pabelanger added a commit to pabelanger/cisco_ios that referenced this issue Feb 6, 2019
@pabelanger
Add tox test to validate parser
b403a5a 
We have an existing test_parser_templates.yaml playbook, lets run it on
every commit to increase our coverage.

Update bindep.txt to support centos-7 (python27 support).

Closes: ansible-network#98
Signed-off-by: Paul Belanger <[email protected]>
pabelanger added a commit to pabelanger/cisco_ios that referenced this issue Feb 6, 2019
@pabelanger
Add tox test to validate parser
7d03ec4 
We have an existing test_parser_templates.yaml playbook, lets run it on
every commit to increase our coverage.

Closes: ansible-network#98
Signed-off-by: Paul Belanger <[email protected]>
pabelanger added a commit to pabelanger/cisco_ios that referenced this issue Feb 6, 2019
@pabelanger
Add tox test to validate parser
3c3646f 
We have an existing test_parser_templates.yaml playbook, lets run it on
every commit to increase our coverage.

Closes: ansible-network#98
Signed-off-by: Paul Belanger <[email protected]>
pabelanger added a commit to pabelanger/cisco_ios that referenced this issue Feb 6, 2019
@pabelanger
Add tox test to validate parser
eff2867 
We have an existing test_parser_templates.yaml playbook, lets run it on
every commit to increase our coverage.

Closes: ansible-network#98
Signed-off-by: Paul Belanger <[email protected]>
Roshna-Raman pushed a commit to Roshna-Raman/cisco_ios that referenced this issue Feb 11, 2019
@pabelanger @Roshna-Raman
Add tox test to validate parser
2779b71 
We have an existing test_parser_templates.yaml playbook, lets run it on
every commit to increase our coverage.

Closes: ansible-network#98
Signed-off-by: Paul Belanger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pabelanger pabelanger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pabelanger @LukeDRussell