@lowjoel hello, thanks for your effort! please also add a changelog fragment of minor_changes type https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment

Thanks! I'm not entirely sure this is ready to merge yet; I think the state changes aren't reported as changes (not sure). The state changes should be reported as changes but the messages are likely meaningless - not sure what should be best. But I've added the changelog fragment (hope it's correct)

hi @lowjoel thanks for this contribution! Wondering whether it's possible to add some tests to validate the functionality, like is done with virt_pool? I think it'd be great to make sure it's behaving as expected. Cheers!

Pretty much duplicated it and replaced it with domain, is there some CI infrastructure I can test that it all works? I could figure out how to test this out using Docker or the like but it'll need some rummaging through docs and could take a while.

Pretty much duplicated it and replaced it with domain, is there some CI infrastructure I can test that it all works? I could figure out how to test this out using Docker or the like but it'll need some rummaging through docs and could take a while.

@lowjoel hello, please take a look at

• https://docs.ansible.com/ansible/devel/community/create_pr_quick_start.html#test-your-changes
• (if a test role is not there yet which you'll figure out from ^) https://docs.ansible.com/ansible/devel/community/collection_contributors/collection_integration_add.html

@lowjoel hello, please take a look at

thanks! though in my case the harder part is to have a libvirt instance to test with because I (obviously) shouldn't be testing this in my production setup.