[PR #9186/a863b628 backport][stable-8] fixing broken check mode in the github_key #9203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* fixing datetime.strftime() * added changelog fragment * Update changelogs/fragments/9186-fix-broken-check-mode-in-github-key.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit a863b62)
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-8/a863b62859541f03d04e9feaaedd4cef9d2e9ff5/pr-9186
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9186 as merged into main (a863b62).
SUMMARY
Fixes #9185 (broken check mode in the github_key.py module)
ISSUE TYPE
COMPONENT NAME
github_key
ADDITIONAL INFORMATION
It looks as if this is a recent regression caused by #8222
The change in the previous PR makes sense but it was missing the datetime class
ie, datetime.strftime(...) instead of datetime.datetime.strftime(...)