From 76dbb584eb5d3ea9f114d5c0edf4303be68df3f9 Mon Sep 17 00:00:00 2001 From: Alexei Znamensky Date: Mon, 25 Nov 2024 23:33:56 +1300 Subject: [PATCH 1/2] scaleway_lb: simplify function logic --- plugins/modules/scaleway_lb.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/modules/scaleway_lb.py b/plugins/modules/scaleway_lb.py index 1083b6da9e3..6cc947755db 100644 --- a/plugins/modules/scaleway_lb.py +++ b/plugins/modules/scaleway_lb.py @@ -228,8 +228,8 @@ def lb_attributes_should_be_changed(target_lb, wished_lb): if diff: return {attr: wished_lb[attr] for attr in MUTABLE_ATTRIBUTES} - else: - return diff + + return {} def present_strategy(api, wished_lb): From f54860effa66217ff7dcf3ef16a3e3ee5d3885af Mon Sep 17 00:00:00 2001 From: Alexei Znamensky Date: Mon, 25 Nov 2024 23:40:41 +1300 Subject: [PATCH 2/2] add changelog frag --- changelogs/fragments/9189-scalway-lb-simplify-return.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/9189-scalway-lb-simplify-return.yml diff --git a/changelogs/fragments/9189-scalway-lb-simplify-return.yml b/changelogs/fragments/9189-scalway-lb-simplify-return.yml new file mode 100644 index 00000000000..39d161f06b0 --- /dev/null +++ b/changelogs/fragments/9189-scalway-lb-simplify-return.yml @@ -0,0 +1,2 @@ +minor_changes: + - scaleway_lb - minor simplification in the code (https://github.com/ansible-collections/community.general/pull/9189).