Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing broken check mode in the github_key #9186

Merged
merged 3 commits into from
Nov 28, 2024
Merged

fixing broken check mode in the github_key #9186

merged 3 commits into from
Nov 28, 2024

Conversation

tomcperry
Copy link
Contributor

SUMMARY

Fixes #9185 (broken check mode in the github_key.py module)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

github_key

ADDITIONAL INFORMATION

It looks as if this is a recent regression caused by #8222
The change in the previous PR makes sense but it was missing the datetime class
ie, datetime.strftime(...) instead of datetime.datetime.strftime(...)

@ansibullbot
Copy link
Collaborator

cc @stpierre
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Nov 24, 2024
@tomcperry
Copy link
Contributor Author

Apologies, but I am unable to run ansible-test right now as I don't have docker available.

Changelog fragment on its way

@tomcperry tomcperry changed the title fixing datetime.strftime() fixing broken check mode in the github_key Nov 24, 2024
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Nov 25, 2024
@felixfontein felixfontein added backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch labels Nov 25, 2024
felixfontein
felixfontein reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this! I've one small comment for the changelog, besides that it looks good!

changelogs/fragments/9186-fix-broken-check-mode-in-github-key.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 25, 2024
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 26, 2024
russoz
russoz approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit a863b62 into ansible-collections:main Nov 28, 2024
129 checks passed
@patchback Patchback
Copy link

patchback bot commented Nov 28, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/a863b62859541f03d04e9feaaedd4cef9d2e9ff5/pr-9186

Backported as #9203

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 28, 2024
@tomcperry @patchback
fixing broken check mode in the github_key (#9186)
b63c4bd 
* fixing datetime.strftime()

* added changelog fragment

* Update changelogs/fragments/9186-fix-broken-check-mode-in-github-key.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a863b62)
@patchback patchback bot mentioned this pull request Nov 28, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Nov 28, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/a863b62859541f03d04e9feaaedd4cef9d2e9ff5/pr-9186

Backported as #9204

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 28, 2024
@tomcperry @patchback
fixing broken check mode in the github_key (#9186)
30e0aad 
* fixing datetime.strftime()

* added changelog fragment

* Update changelogs/fragments/9186-fix-broken-check-mode-in-github-key.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a863b62)
@patchback Patchback
Copy link

patchback bot commented Nov 28, 2024 •
edited
Loading

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/a863b62859541f03d04e9feaaedd4cef9d2e9ff5/pr-9186

Backported as #9205

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Nov 28, 2024
Merged
patchback bot pushed a commit that referenced this pull request Nov 28, 2024
@tomcperry @patchback
fixing broken check mode in the github_key (#9186)
c4b140e 
* fixing datetime.strftime()

* added changelog fragment

* Update changelogs/fragments/9186-fix-broken-check-mode-in-github-key.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a863b62)
@patchback patchback bot mentioned this pull request Nov 28, 2024
Merged
@felixfontein
Copy link
Collaborator

@tomcperry thanks for fixing this!
@russoz thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Nov 28, 2024
@patchback @tomcperry
[PR #9186/a863b628 backport][stable-8] fixing broken check mode in th…
b1d21aa 
…e github_key (#9203)

fixing broken check mode in the github_key (#9186)

* fixing datetime.strftime()

* added changelog fragment

* Update changelogs/fragments/9186-fix-broken-check-mode-in-github-key.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a863b62)

Co-authored-by: tomcperry <[email protected]>
felixfontein pushed a commit that referenced this pull request Nov 28, 2024
@patchback @tomcperry
[PR #9186/a863b628 backport][stable-9] fixing broken check mode in th…
1d9367e 
…e github_key (#9204)

fixing broken check mode in the github_key (#9186)

* fixing datetime.strftime()

* added changelog fragment

* Update changelogs/fragments/9186-fix-broken-check-mode-in-github-key.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a863b62)

Co-authored-by: tomcperry <[email protected]>
felixfontein pushed a commit that referenced this pull request Nov 28, 2024
@patchback @tomcperry
[PR #9186/a863b628 backport][stable-10] fixing broken check mode in t…
163f3ee 
…he github_key (#9205)

fixing broken check mode in the github_key (#9186)

* fixing datetime.strftime()

* added changelog fragment

* Update changelogs/fragments/9186-fix-broken-check-mode-in-github-key.yml

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a863b62)

Co-authored-by: tomcperry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken check mode in github_key module
4 participants
@tomcperry @ansibullbot @felixfontein @russoz